pkp/pkp-lib#4787 Reviewer suggestions #4459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
touhidurabir
force-pushed
the
i4787_main
branch
from
42165fe to
1bd3b67
Compare
touhidurabir
force-pushed
the
i4787_main
branch
from
f99fdd0 to
b167584
Compare
touhidurabir
force-pushed
the
i4787_main
branch
3 times, most recently
from
1a222c6 to
4beceee
Compare
touhidurabir
commented
Nov 4, 2024
Comment on lines
1
to
23
| <?php | ||
|
|
||
| /** | ||
| * @file classes/migration/upgrade/v3_5_0/I4787_ReviewSuggestions.php | ||
| * | ||
| * Copyright (c) 2024 Simon Fraser University | ||
| * Copyright (c) 2024 John Willinsky | ||
| * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
| * | ||
| * @class I4787_ReviewSuggestions.php | ||
| * | ||
| * @brief Add reviewer suggestion related tables | ||
| * | ||
| */ | ||
|
|
||
| namespace APP\migration\upgrade\v3_5_0; | ||
|
|
||
| class I4787_ReviewSuggestions extends \PKP\migration\upgrade\v3_5_0\I4787_ReviewSuggestions | ||
| { | ||
| protected string $CONTEXT_TABLE = 'journals'; | ||
| protected string $CONTEXT_SETTINGS_TABLE = 'journal_settings'; | ||
| protected string $CONTEXT_COLUMN = 'journal_id'; | ||
| } |
There was a problem hiding this comment.
This should probably go to a v3_6_0 folder .
touhidurabir
commented
Nov 4, 2024
dbscripts/xml/install.xml
Outdated
| @@ -39,6 +39,7 @@ | |||
| <migration class="PKP\migration\install\TombstoneMigration" /> | |||
| <migration class="PKP\migration\install\DoiMigration" /> | |||
| <migration class="PKP\migration\install\InstitutionsMigration" /> | |||
| <migration class="PKP\migration\install\ReviewerSuggestionsMigration" /> | |||
There was a problem hiding this comment.
For now , this is only a place holder as this should be a part of 3.6.0 upgrade process .
touhidurabir
force-pushed
the
i4787_main
branch
from
fe6d370 to
9cc4bde
Compare
touhidurabir
force-pushed
the
i4787_main
branch
3 times, most recently
from
e6caceb to
360a095
Compare
touhidurabir
force-pushed
the
i4787_main
branch
from
3e3e2a5 to
bc26428
Compare
…sting suggestion
touhidurabir
force-pushed
the
i4787_main
branch
from
b1cd5ea to
e8fc6e7
Compare
defstat
requested changes
Feb 1, 2025
There was a problem hiding this comment.
thanks @touhidurabir! Only some wording comments for this one.
| msgstr "Reviewer Suggestion at Submission" | ||
|
|
||
| msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.description" | ||
| msgstr "Author can suggest few potntial reviewers before completing the submission which can streamline the review process and provide valuable input for editorial team." |
There was a problem hiding this comment.
A spelling error here:
"potntial" => "potential"
Is there a limit on the potential reviewers that can be suggested? if not, why we are writing "few" here?
This comment can apply to default.submission.step.reviewerSuggestions in pkp-lib PR also were we state "the option to suggest 2/3 potential reviewers".
i understand that this is a "suggestion" to the author, but, maybe, the wording should be reconsidered
| msgstr "Author can suggest few potntial reviewers before completing the submission which can streamline the review process and provide valuable input for editorial team." | ||
|
|
||
| msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.label" | ||
| msgstr "Allow authors to suggest potential reviews at submission process" |
There was a problem hiding this comment.
"potential reviews" => "potential reviewers" perhaps, to be more clear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for pkp/pkp-lib#4787